ChatGPT's update to harden software and run db updates.

tests/deployment_tools.py

@@ -19,6 +19,7 @@ try:
             names=archive.namelist();manifest=json.loads(archive.read('release-manifest.json'))
             check(not any(name.startswith(('.tools/','.git/','tests/','nbproject/')) or name.endswith('settings.local.xml') for name in names),'Release excludes local credentials, backups, Git metadata, and tests')
             check(all(name in names for name in ['classes/LedgerService.php','classes/EmailVerification.php','bin/migrate-production.php','migrations/003_production.sql','js/jquery-3.7.1.min.js']),'Release includes new classes, migration, and updated jQuery')
+            check(all(name in names for name in ['classes/MemberSummary.php','classes/ClubFormModals.php','js/club-modals.js','classes/MfaSecurityNotifications.php','classes/MfaSetupQr.php','classes/MfaService.php','classes/MfaClock.php','classes/BoundedList.php','classes/ClubResources.php','bin/migrate-security-capacity.php','migrations/005_security_capacity.sql','classes/DatabaseTransaction.php','js/tickets.js','classes/TenantAccess.php','classes/ClubInvitations.php','classes/ClubTickets.php','bin/migrate-tenants.php','migrations/004_tenants.sql','classes/MaintenanceValidation.php','classes/BackupValidation.php','js/rich-text.js','js/suneditor-3.3.3.min.js','css/suneditor-3.3.3.min.css','THIRD-PARTY-NOTICES.md','browser-dependencies.json']) and 'js/ckeditor.js' not in names,'Release includes replacement editor, license, integrity metadata, and new validators')
             check(all(hashlib.sha256(archive.read(name)).hexdigest()==digest for name,digest in manifest.items()),'Release manifest verifies every packaged file')
         binary=os.environ.get('HCR_DUMP_BINARY') or shutil.which('mariadb-dump')
         if not binary:
@@ -33,6 +34,11 @@ try:
         check(not list(Path(temporary).glob('hcr-connection-*')),'Backup credentials file is removed after completion')
         result=subprocess.run(PHP+['bin/backup-database.php',str(ROOT/'.tools')],cwd=ROOT,env=env,capture_output=True)
         check(result.returncode!=0,'Backup tool rejects storage within the application tree')
+        failed_directory=Path(temporary)/'failed-job';failed_directory.mkdir()
+        env['HCR_DUMP_BINARY']=PHP[0] # A real executable that rejects dump arguments.
+        result=subprocess.run(PHP+['bin/backup-database.php',str(failed_directory)],cwd=ROOT,env=env,capture_output=True)
+        check(result.returncode!=0,'Dump process failure produces a failing job exit status')
+        check(not list(failed_directory.iterdir()),'Failed backup leaves no credentials, partial dump, or success metadata')
     for path in ['/.tools/backups/probe.sql','/migrations/003_production.sql','/bin/check-health.php','/xml/settings.xml','/release-manifest.json']:
         check(app.request(path)[0] in [403,404],'Development router denies '+path)
 finally:app.close()